Update dependencies and move to ESM #267
Conversation
|
Thanks. Would you be willing to move to use |
|
@sindresorhus Thanks for the suggestion! I didn't know about this package. I'll update the PR again over the weekend. |
|
I migrated to I think it works as expected once nodejs/node#34314 has landed on Node 15. |
readme.md
Outdated
| ```js | ||
| const gulp = require('gulp'); | ||
| const rev = require('gulp-rev'); | ||
| import {src, dest} from 'gulp'; |
There was a problem hiding this comment.
I would prefer to keep gulp a default import.
readme.md
Outdated
| exports.default = () => ( | ||
| gulp.src('src/*.js') | ||
| exports.default = async () => { | ||
| const {default: rev} = await import('gulp-rev'); |
There was a problem hiding this comment.
➡️ 1d6480d
My mistake, I thought that we couldn't import the other packages of the examples using ES import
| if (path.extname(file.path) === '.map') { | ||
| t.is(file.path, 'pastissada-d41d8cd98f.css.map'); | ||
| } | ||
| } |
There was a problem hiding this comment.
Do an assert for the correct file count too. Currently, if the stream never emits, it would not be caught and test would succeed.
I think we can just target Node.js 16. This is a dev tool anyway, not a reusable package. |
|
Nice work 👍 |
2 participants
Thanks for releasing a new version of
vinyl-file🙏 This time, I want to updategulp-rev!What's new?
avatests usingp-eventxoThe tests are passing in my repo.
I also updated some examples in the readme but I am not too sure about the ones that mix ESM and CJS modules.