Skip to content

Conversation

@naaa760
Copy link

@naaa760 naaa760 commented Nov 17, 2025

Summary

  • add Google Drive "Get File" and Notion "Create Page in Database" operations to enable complete workflow automation for AI agents processing files and outputting results to Notion databases.

fix: #1939

Type of Change

  • New feature

Testing

  • changes compile successfully with no TypeScript errors or linting issues. Implementation follows existing code patterns and integrates with current workflow system without breaking existing functionality.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the CLA

@vercel
Copy link

vercel bot commented Nov 17, 2025

@naaa760 is attempting to deploy a commit to the Sim Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 17, 2025

Greptile Summary

  • Added Google Drive "Get File" operation with file selector UI and export format options for Google Workspace files
  • Added Notion "Create Page in Database" operation enabling direct page creation in databases using database_id parent type
  • Modified notion_create_page tool to accept parentType parameter distinguishing between page and database parents

Confidence Score: 3/5

  • PR has a critical logic issue in database page creation that may cause runtime failures
  • Google Drive implementation is solid (score 5/5), but Notion database page creation has a critical flaw - it assumes the title property is always named "title", when databases can have custom property names like "Name", "Task", etc. This will cause API errors when creating pages in databases with non-standard title property names.
  • apps/sim/tools/notion/create_page.ts requires attention for database title property handling

Important Files Changed

Filename Overview
apps/sim/tools/notion/create_page.ts Extended to support database_id parent type, but title property handling assumes hardcoded "title" name which may not match database schema

Sequence Diagram

sequenceDiagram
    participant User
    participant Workflow
    participant GoogleDrive
    participant NotionDB
    
    User->>Workflow: Trigger workflow
    Workflow->>GoogleDrive: Get File operation
    GoogleDrive-->>Workflow: Return file content
    Workflow->>NotionDB: Create Page in Database
    NotionDB-->>Workflow: Page created
    Workflow-->>User: Workflow complete
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. apps/sim/tools/notion/create_page.ts, line 78-94 (link)

    logic: when creating a page in a database (parentType is database_id), the title property may not be named "title" - databases can have different property names for their title column (e.g., "Name", "Task", etc.). This assumes the title property is always named "title", which is only true for regular pages.

    Check the database schema first to get the correct title property name, or allow the user to specify which property should receive the title value.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQUEST] Add operations for Drive and Notion

1 participant