Skip to content

Conversation

@exMagic
Copy link
Contributor

@exMagic exMagic commented Nov 25, 2024

No description provided.

@runger1101001 runger1101001 changed the base branch from master to dev November 25, 2024 11:17
@runger1101001
Copy link
Member

Hi @exMagic ,

Thanks for correcting the typos.... unfortunately we accept contributions only to the dev branch of the repository, and your PR does not merge cleanly when I change it over to that branch.

If you're really keen on fixing these typos please make another PR based on the dev branch of the repository, as it looks like a lot of work to fix up this one, for only modest gain.

@askuric
Copy link
Member

askuric commented Nov 25, 2024

I'm wondering, how is this even possible. The dev branch is behind the master branch in this repo. :/

@runger1101001
Copy link
Member

Hmmmm.... you're right. I think I didn't look closely enough. How do we want to handle it? It would merge very cleanly against the master branch, actually...

@runger1101001 runger1101001 reopened this Nov 25, 2024
@runger1101001 runger1101001 changed the base branch from dev to master November 25, 2024 11:37
@askuric askuric merged commit 4e7b14d into simplefoc:master Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants