Skip to content

Conversation

@mcells
Copy link
Contributor

@mcells mcells commented Nov 10, 2023

Fixed a few wrong or out-of-date points and corrected the spelling/grammar in a few files. The docs are really nice and comprehensive, but that also means a lot to read through to fix all errors. So i didn´t even go through half the files.

In the "from_scratch.md" I added a note about being more careful when using motors for the first time, especially noting the danger of too low of a phase resistance. (Happens to all of us... 😉 ) Is that ok this way? I tried to phrase it as optimistic as possible, to keep with the spirit of the docs, but the important warning about voltage limit is still a wall of text.

I am basing ths PR on the master branch, as the changes also concern the current release of the library and backporting to dev seems to have been done in this repo before.

@runger1101001
Copy link
Member

Thanks a lot for this. I'm going to merge it, but next time please please against the dev branch :-)

@runger1101001 runger1101001 merged commit 497f638 into simplefoc:master Dec 1, 2023
@mcells
Copy link
Contributor Author

mcells commented Dec 1, 2023

Thanks, wont happen again :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants