Import file API #14
Open
Import file API #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
…m a given URL and commits it.
takesson
requested changes
Sep 22, 2025
src/main/java/se/simonsoft/cms/transform/rest/TransformResource.java
Outdated
Show resolved
Hide resolved
src/main/java/se/simonsoft/cms/transform/rest/TransformResource.java
Outdated
Show resolved
Hide resolved
src/main/java/se/simonsoft/cms/transform/rest/TransformResource.java
Outdated
Show resolved
Hide resolved
src/main/java/se/simonsoft/cms/transform/service/TransformServiceXsl.java
Outdated
Show resolved
Hide resolved
src/main/java/se/simonsoft/cms/transform/service/TransformServiceXsl.java
Outdated
Show resolved
Hide resolved
src/main/java/se/simonsoft/cms/transform/rest/TransformResource.java
Outdated
Show resolved
Hide resolved
takesson
reviewed
Sep 22, 2025
src/main/java/se/simonsoft/cms/transform/rest/TransformResource.java
Outdated
Show resolved
Hide resolved
takesson
reviewed
Sep 22, 2025
src/main/java/se/simonsoft/cms/transform/service/TransformServiceXsl.java
Outdated
Show resolved
Hide resolved
…ort for importing content alongside url.
takesson
reviewed
Oct 21, 2025
| final CmsItem location = itemLookup.getItem(repository.getItemId(relPath, null)); | ||
| final CmsItemProperties locationProps = location.getProperties(); | ||
| final boolean isShardParent = isCmsClass(locationProps, CMS_CLASS_SHARDPARENT); | ||
| final boolean hasNamePattern = locationProps.containsProperty(PROPNAME_CONFIG_ITEMNAMEPATTERN); |
Member
There was a problem hiding this comment.
If isShardParent, then we can require hasNamePattern.
Error message from cms-fonto:
if (!locationProps.containsProperty(PROPNAME_CONFIG_ITEMNAMEPATTERN)) {
String msg = MessageFormatter.format("Location does not define a name pattern: {}", parentFolder).getMessage();
logger.error(msg);
throw new IllegalArgumentException(msg);
}
takesson
requested changes
Oct 21, 2025
| final CmsItem location = itemLookup.getItem(repository.getItemId(relPath, null)); | ||
| final CmsItemProperties locationProps = location.getProperties(); | ||
| final boolean isShardParent = isCmsClass(locationProps, CMS_CLASS_SHARDPARENT); | ||
| final boolean hasNamePattern = locationProps.containsProperty(PROPNAME_CONFIG_ITEMNAMEPATTERN); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://pds-svn-gbg.pdsvision.net/trac/SubversionCMS/ticket/1861
Task: https://simonsoft.slack.com/lists/T04L7JSEC/F07PTMY5G6P?record_id=Rec092VEJLABZ