Fixed bug when setting update_hook to null twice #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugikhan
added a commit
to powersync-ja/sqlite3.dart
that referenced
this pull request
Nov 28, 2024
* Adding uuid.c example * Expand readme * Link custom extension example * Fix extension tests in CI * Add a DynamicBuffer for faster VFS implementations. * Switch to Uint8Buffer. * Support 16KiB page sizes on Android * Avoid copying for writes to memory * Changelog entry * Re-compile sqlite3 for CI * Update sqlite3 in wasm build * Implement remote file system * Fix web tests * Prepare to publish sqlite3 web * Upgrade lints * Update sqlite to 3.47.0 * Raise version number * Support custom VFS on native platforms * Reformat headers * Mark ffi vfs test as using ffi * Update simulator for iOS integration tests * IndexedDb: Store blobs as array buffers if necessary * Add changelog entry * Add sqlite3_test utility * Mention sqlite test in top-level readme * Prepare 2.5.0 release * Fixed bug when setting update_hook to null twice (simolus3#269) --------- Co-authored-by: Rody Davis <[email protected]> Co-authored-by: Simon Binder <[email protected]> Co-authored-by: Ralf Kistner <[email protected]> Co-authored-by: Dominic Jack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't believe this was causing any issues, but it looked smelly.