Skip to content

Add version change support to Windows install script #6304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pjanotti
Copy link
Contributor

Description:
Change the Windows install script to support changing the collector version, without requiring manual uninstall.

Testing:
Added a new test to cover the main scenario for this change

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.85%. Comparing base (0f83433) to head (99e5da8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6304      +/-   ##
==========================================
- Coverage   44.90%   44.85%   -0.06%     
==========================================
  Files         390      390              
  Lines       26994    26994              
==========================================
- Hits        12122    12107      -15     
- Misses      14005    14017      +12     
- Partials      867      870       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjanotti pjanotti changed the title [DRAFT] Add version change support to Windows install script Add version change support to Windows install script Jun 11, 2025
@pjanotti pjanotti marked this pull request as ready for review June 11, 2025 04:38
@pjanotti pjanotti requested review from a team as code owners June 11, 2025 04:38
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of questions and clarifications, just trying to learn more about Windows here. 👍

@pjanotti pjanotti merged commit 7252f07 into signalfx:main Jun 12, 2025
199 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2025
@pjanotti pjanotti deleted the ps-install-script-to-support-collector-update branch June 12, 2025 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants