-
Notifications
You must be signed in to change notification settings - Fork 6
[DO NOT MERGE THIS PR] Prepare for release v1.5.1 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
04c87cc to
50154e3
Compare
ralgozino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some non-blocking comments
docs/releases/v1.5.1.md
Outdated
|
|
||
| ## Upgrade Path | ||
|
|
||
| This release contains only a path change and hence updating the following components should be enough: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/path/patch/g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should write that there are no breaking changes and maybe link to elasticsearch's release notes for quick access: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.21.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, there are some known issues on v6.8.9 that might be worthy specify here as reference:
https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.9.html
Slow loggers can cause Log4j loggers to leak over time. When a new index is created, a new Log4j logger is associated with it. However, when an index is deleted, Log4j keeps an internal reference to its loggers that results in a memory leak #57228 (issue: #56171)
This issue is fixed in Elasticsearch 6.8.10 and 7.7.1.
Java based - formats with 8 prefix - week based parsing and calculations are using JDK default calendar data provider which is Sunday,1. Sunday is considered first day of a week and it requires only 1 day in a week to for the first week of the year. It can be worked around by using locale which is based on ISO8601 rule (Monday,4) - for instance en-GB This issue is fixed in Elasticsearch 7.7 elastic/elasticsearch#48209
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ralgozino the known of v.6.8.9 were fixed apparently in v6.8.10. And it doesn't seem to be present in v6.8.21
|
LGTM |
No description provided.