Add support for scientific notation and long decimal numbers #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Uncaught SyntaxError: Cannot convert xxxxx to a BigIntwhen encountering numbers in scientific notation or a wide decimal number(>15 chars).This PR uses
Number.isSafeIntegerinstead ofstring.lenght > 15to identify BigInt scenarios.It also treat numbers with fractional parts(decimal) or numbers in scientific notation as Number(double) instead of trying to convert it into BigInt.
For example,
1.79e+308should be treated as a double, not a long integer.I added a
testwith additional test data to support my use case.It would be nice if you can merge my Pull Request. I am using my fork in the meantime.