[Forwardport] Ensure DeploymentConfig Reader always returns an array #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- several messages are updated
- several messages are updated
- several messages are updated
- several messages are updated
# Conflicts: # dev/tests/js/JsTestDriver/testsuite/mage/search/regular-search-test.js
- several messages are updated
- failed FATs are fixed
# Conflicts: # app/code/Magento/Eav/Test/Unit/Model/Attribute/GroupRepositoryTest.php
- failed Units are fixed
- failed FATs are fixed
# Conflicts: # app/code/Magento/Eav/Model/Entity/Attribute/Backend/AbstractBackend.php # dev/tests/api-functional/testsuite/Magento/Customer/Api/AccountManagementTest.php # dev/tests/integration/testsuite/Magento/Catalog/Controller/Adminhtml/CategoryTest.php
- failed tests are fixed
- Unit tests are fixed
…the previous step - sample test fixes
- Unit tests are fixed
…amic instead of hardcoding
…ls due to missing cache clear - add new cache clear step
…agento#13506 - Merge Pull Request magento#13506 from pmclain/magento2:feature/swatch-config - Merged commits: 1. dfd734e
…lidators to dynamic instead of hardcoding magento#13615 - Merge Pull Request magento#13615 from p-bystritsky/magento2:forwardport-pull-13462 - Merged commits: 1. d3d6f70
…ger Block magento#13616 - Merge Pull Request magento#13616 from p-bystritsky/magento2:forwardport-pull-13485 - Merged commits: 1. 7a66968
Fixed issues: - MAGETWO-84702: [SE Dev] Error Messages edits, part 1 (966 of 1166 total)
…lidators to dynamic instead of hardcoding magento#13615
…elop [Pangolin] Deliver Test Fixes - MQE-741: Two steps with same step key, the later step will overwrite the previous step - MQE-799: Bump MFTF version to 2.0.3 and test fixes
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#13616: Forwardport-pull-13485: Update code formatting in Swagger Block (by @p-bystritsky) - magento#13615: Forwardport-pull-13462: Switch updatecart qty input validators to dynamic instead of hardcoding (by @p-bystritsky) - magento#13506: Fix load order of view.xml when loading Swatch config (by @pmclain) Fixed GitHub Issues: - magento#12647: Image Swatch size change not working (reported by @joachim-havloujian) has been fixed in magento#13506 by @pmclain in 2.3-develop branch Related commits: 1. dfd734e
[CMS Team 3] Sprint 1
…n on invalid config
sidolov
force-pushed
the
2.3-develop-PR-port-13584
branch
from
26262a3 to
4ac68a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#13584
Description
When a empty configuration file is ready, this could result in loading invalid configuration, eg. just
1instead of an array. This will lead to problems with other code, expecting a valid array.Fixed Issues
magento/pull/13090
Manual testing scenarios
Create an empty file as app/etc/env.php and run the CLI installer