Forward message is missing attachment id #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkulic
reviewed
Feb 7, 2023
| serde_json::from_str(forwarded_msg) | ||
| .kind(ErrorKind::Malformed, "Unable deserialize forwarded message")?, | ||
| ) | ||
| .id(generate_attachment_id()) |
Contributor
There was a problem hiding this comment.
Could you use the function above generate_message_id, maybe we could rename it? I do not like having two functions which have exactly the same body.
dkulic
requested changes
Aug 2, 2023
Contributor
dkulic
left a comment
dkulic
left a comment
There was a problem hiding this comment.
Avoid having two functions with exactly the same code.
generate_attachment_id and generate_message_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIDComm rust implementation does not include the id of the attachment, when forwarding the message.
On other hand didcomm-jvm validates whether the attachment contains the id and fails.
This makes these two libraries incompatible.
Attachment ID is optional, but recommended.