Skip to content

fix: update macos shorebird.yaml before signing #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 21, 2025
Merged

fix: update macos shorebird.yaml before signing #73

merged 6 commits into from
Jan 21, 2025

Conversation

bryanoltman
Copy link

Moves the generation of the app's shorebird.yaml into an earlier build phase.

Prior to this change, shorebird macOS apps would fail validation:

codesign -vvv --deep --strict /path/to/my.app

would fail with:

build/macos/Build/Products/Release-stable/Shorebird Example.app: a sealed resource is missing or invalid
In subcomponent: /Users/bryanoltman/shorebirdtech/samples/flavors/build/macos/Build/Products/Release-stable/Shorebird Example.app/Contents/Frameworks/App.framework
file modified: /Users/bryanoltman/shorebirdtech/samples/flavors/build/macos/Build/Products/Release-stable/Shorebird Example.app/Contents/Frameworks/App.framework/Versions/Current/Resources/flutter_assets/shorebird.yaml

With this change:

Build/Products/Release-stable/Shorebird Example.app: valid on disk
Build/Products/Release-stable/Shorebird Example.app: satisfies its Designated Requirement

@bryanoltman bryanoltman merged commit 0f22338 into shorebird/dev Jan 21, 2025
3 of 4 checks passed
@bryanoltman bryanoltman deleted the bo/macos-shorebird-yaml branch January 21, 2025 22:43
@bryanoltman bryanoltman mentioned this pull request Jan 21, 2025
Merged
bryanoltman added a commit that referenced this pull request Jan 22, 2025
@bryanoltman
fix: update macos shorebird.yaml before signing (#73)
73fb01b 
* fix: update macos shorebird.yaml before signing

* fix test

* tests

* Move shorebird.yaml processing to assets.dart to update the file on copy

* Remove unnecessary update of shorebird.yaml in ios/mac.dart

* Handle empty string flavor
bryanoltman added a commit that referenced this pull request Feb 6, 2025
@bryanoltman
fix: update macos shorebird.yaml before signing (#73)
0aabeb4 
* fix: update macos shorebird.yaml before signing

* fix test

* tests

* Move shorebird.yaml processing to assets.dart to update the file on copy

* Remove unnecessary update of shorebird.yaml in ios/mac.dart

* Handle empty string flavor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@eseidel eseidel Awaiting requested review from eseidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanoltman @felangel