Feature/disable shipping methods on paypal #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tcommerce/flex-ruby-gem into feature/disable_shipping_methods_on_paypal
| # It deals with line items total, sub total, tax calculations and | ||
| # Also deals with discounted line items and discounts inorder to send to paypal | ||
| # | ||
| # |
There was a problem hiding this comment.
This class also does something for gift cards now; it might need to be updated.
Contributor
There was a problem hiding this comment.
Thanks. It's simply subtracting gift card amount from total amount but I will update it.
simonireilly
approved these changes
Apr 30, 2020
simonireilly
left a comment
simonireilly
left a comment
There was a problem hiding this comment.
I have reviewed with comments, but obviously its code already in production for some months. I am not sure my review would add very much value.
Co-authored-by: Simon <[email protected]>
…hiftcommerce/flex-ruby-gem into feature/disable_shipping_methods_on_paypal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: