Skip to content

Update example in README.md to use @teamwork/websocket-json-stream #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

Update example in README.md to use @teamwork/websocket-json-stream #276

merged 1 commit into from
Mar 7, 2019

Conversation

@gkubisa
Copy link
Contributor

@gkubisa gkubisa commented Mar 5, 2019

No description provided.

@coveralls
Copy link

coveralls commented Mar 5, 2019

Coverage Status

Coverage remained the same at 95.85% when pulling 31be02e on Teamwork:teamwork-websocket-json-stream into 02187ca on share:master.

2 similar comments
@coveralls
Copy link

coveralls commented Mar 5, 2019

Coverage Status

Coverage remained the same at 95.85% when pulling 31be02e on Teamwork:teamwork-websocket-json-stream into 02187ca on share:master.

@coveralls
Copy link

coveralls commented Mar 5, 2019

Coverage Status

Coverage remained the same at 95.85% when pulling 31be02e on Teamwork:teamwork-websocket-json-stream into 02187ca on share:master.

@gkubisa gkubisa mentioned this pull request Mar 5, 2019
Closed
ericyhwang
ericyhwang approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@ericyhwang ericyhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Before I merge, the example's otherwise fine with you?

Side note - I checked with Nate quickly, and when updating examples, he actually started on improving the client's handling of certain websocket libraries. Not directly related to the server websocket library.

@gkubisa
Copy link
Contributor Author

gkubisa commented Mar 6, 2019

Yes, it looks good to me.

@ericyhwang ericyhwang merged commit 17de0fd into share:master Mar 7, 2019
@gkubisa gkubisa deleted the teamwork-websocket-json-stream branch March 7, 2019 07:59
@ericyhwang ericyhwang mentioned this pull request May 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericyhwang ericyhwang ericyhwang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gkubisa @coveralls @ericyhwang