Skip to content

Conversation

billwashere
Copy link
Contributor

This commit adds Connection Pooling as well as the ability to pass database details via environment arguments.

Added some semicolons, also PostgresDB.pg_config no longer needs to be saved
@nornagon
Copy link
Member

Awesome, thanks for separating this out! I pulled it down locally to do some testing and it looks like the old style of passing a database URL a la postgres://$HOST:$PORT/$DB_NAME is no longer supported in pg. That's a breaking change, so we should document it in a changelog (that doesn't yet exist) and bump the major version.

@nornagon nornagon merged commit 3ae70bf into share:master Mar 20, 2018
@billwashere
Copy link
Contributor Author

You should be able to pass in the connection string by going

{
  connectionString:"postgres://$HOST:$PORT/$DB_NAME"
} We

Instead of host and port

@nornagon
Copy link
Member

(...belatedly), i've published v3.0.0 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants