Fix to work with the latest version of mongo driver #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateps
requested changes
Jul 3, 2019
| // TODO: Deprecate the ability to pass mongo options implicitly | ||
| var mongoOptions; | ||
| if (options.mongoOptions) { | ||
| mongoOptions = options.mongoOptions; |
There was a problem hiding this comment.
I like this change of being explicit about which options to pass to mongo in a separate object, but let's not do the second part where we try and make the old options style backward compatible. I think it is reasonable to expect people to update their connection instantiation code as they switch drivers.
| var mongoOptions; | ||
| if (options.mongoOptions) { | ||
| mongoOptions = options.mongoOptions; | ||
| } else { |
There was a problem hiding this comment.
I'd remove this part where we delete all the sharedb-mongo options and instead just require people to update their options if they want to use the new driver
|
Thanks for the help! I'm closing this, since it is being addressed slightly differently with #83 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of
mongodbthrows error on unknown options. In a simple ShareDB usecase (when a separatemongoPolldatabase is not used) mongo gets its options from the mutual pool of options for mongo and for ShareDB. This leads to errors likeallowAllQueries options is not supportedinmongodb.This pull request fixes this issue by adding sanitization of options (removes all sharedb-specific options) before passing them to mongo.
Suggestion: Passing mongo options implicitly should be deprecated. We should always get mongo options from
mongoOptionsfield.