Switch to named imports #1730
Draft
Switch to named imports #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alexeyr-ci
force-pushed
the
alexeyr/improve-tree-shakability
branch
4 times, most recently
from
58c9ad8 to
9878c51
Compare
|
@alexeyr-ci2 What's the point of this PR? |
alexeyr-ci
force-pushed
the
alexeyr/improve-tree-shakability
branch
2 times, most recently
from
44b60c5 to
49b623c
Compare
|
@justin808 Added summary. |
alexeyr-ci
force-pushed
the
alexeyr/improve-tree-shakability
branch
from
49b623c to
25eece5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make imports from
react-on-railstree-shakable to improve bundle size.This is a breaking change; do not merge until we start working on 16.0.0 (and recommended after #1710)!
Pull Request checklist
sideEffects: falsein package.json once everything works otherwise and verify it doesn't break anything. Check bundle size benefits.This change is