Skip to content

Fix test for more restrictive xarray multi-index #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2022
Merged

Fix test for more restrictive xarray multi-index #854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sgkit/tests/test_variables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@ def test_variables__variables_registered():

@pytest.fixture()
def dummy_ds():
# foo is a data variable, bar is a coordinate
# foo ans baz are data variables, bar is a coordinate
return xr.Dataset(
{
"foo": ("d1", np.asarray([1, 2, 3])),
"bar": np.asarray([1, 2, 3]),
"baz": ("d1", np.asarray([4, 5, 6])),
}
)

Expand Down Expand Up @@ -82,20 +83,24 @@ def test_variables__multiple_specs(dummy_ds: xr.Dataset) -> None:
def test_variables__whole_ds(dummy_ds: xr.Dataset) -> None:
spec_foo = ArrayLikeSpec("foo", "foo doc", kind="i", ndim=1)
spec_bar = ArrayLikeSpec("bar", "bar doc", kind="i", ndim=1)
spec_baz = ArrayLikeSpec("baz", "baz doc", kind="i", ndim=1)
try:
SgkitVariables.register_variable(spec_foo)
with pytest.raises(ValueError, match="`foo` already registered"):
SgkitVariables.register_variable(spec_foo)
SgkitVariables.register_variable(spec_bar)
SgkitVariables.register_variable(spec_baz)
variables.validate(dummy_ds)
finally:
SgkitVariables.registered_variables.pop("foo", None)
SgkitVariables.registered_variables.pop("bar", None)
SgkitVariables.registered_variables.pop("baz", None)


def test_variables_in_multi_index(dummy_ds: xr.Dataset) -> None:
# create a multi index
ds = dummy_ds.set_index({"ind": ("foo", "bar")})
# variables must share a dimension since https://github.com/pydata/xarray/pull/5692
ds = dummy_ds.set_index({"ind": ("foo", "baz")})

spec = ArrayLikeSpec("foo", "foo doc", kind="i", ndim=1)
variables.validate(ds, spec)