Skip to content

Conversation

tomwhite
Copy link
Collaborator

@tomwhite tomwhite commented Mar 8, 2021

Fixes #477

Copy link
Collaborator

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but idid you mean to hit requirements?

requirements.txt Outdated
@@ -1,7 +1,7 @@
numpy
xarray
dask[array] == 2021.02.0
distributed == 2021.02.0
dask[array]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this undoes earlier PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it would go in after #482, but actually it is independent. I've rebased to remove #482 from this PR.

@tomwhite tomwhite force-pushed the xarray-upstream-fix branch from 9074c04 to 1a02ccb Compare March 8, 2021 16:57
@codecov-io
Copy link

codecov-io commented Mar 8, 2021

Codecov Report

Merging #485 (1a02ccb) into master (12223d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #485   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         2389      2389           
=========================================
  Hits          2389      2389           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12223d2...1a02ccb. Read the comment docs.

@tomwhite tomwhite added the auto-merge Auto merge label for mergify test flight label Mar 8, 2021
@mergify mergify bot merged commit 52b0716 into sgkit-dev:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Auto merge label for mergify test flight
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream build failing for 2 weeks
3 participants