-
Notifications
You must be signed in to change notification settings - Fork 299
allow scrolling past child layer, when a new scroll starts at the end of child layer #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow scrolling past child layer, when a new scroll starts at the end of child layer #465
Conversation
7d38381
to
b79cac5
Compare
5c026ca
to
5618b78
Compare
☔ The latest upstream changes (presumably #488) made this pull request unmergeable. Please resolve the merge conflicts. |
5618b78
to
685b2af
Compare
r? @pcwalton |
685b2af
to
87ffa1d
Compare
To summarize what was discussed in servo/servo#13249
|
Is this ready for review and ready to go? |
@pcwalton yes it is, thank you for your time. |
@pcwalton since from the issue itself it might not be clear what the goal of this PR is, there are two:
See the comments above for links to the discussions around this within the issue. |
2e46231
to
bb584cf
Compare
bb584cf
to
3b33c0e
Compare
☔ The latest upstream changes (presumably #517) made this pull request unmergeable. Please resolve the merge conflicts. |
@gterzian Let me know if you need my input for that. I'm sorry that my change stomped on yours! |
@mrobinson thanks for your offer of input, and no problem at all! 😄 Let me get a better look at the changes, and test the latest behaviour, then I'll get back to you... |
@pcwalton @glennw ok from my initial testing it seems that the behavior suggested in #465 (comment) is still something that needs to be implemented. @mrobinson perhaps it's best if I wait until the servo part of you work has been merged, and then use that as a basis for exploring how to re-implement my changes? |
closing, in favor of #533 |
WIP for servo/servo#13249
This change is