Skip to content

Allow the generated macros to have documentation #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

richard-uk1
Copy link
Contributor

@richard-uk1 richard-uk1 commented Nov 22, 2017

This PR provides functionality to add documentation to the macros created using string_cache_codegen.

It also copies the example from the README to the crate root docs.


This change is Reviewable

@jdm
Copy link
Member

jdm commented Nov 22, 2017

@bors-servo: r+
Nice improvement!

@bors-servo
Copy link
Contributor

📌 Commit 8b33173 has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit 8b33173 with merge 4b80f2d...

bors-servo pushed a commit that referenced this pull request Nov 22, 2017
Allow the generated macros to have documentation

This PR provides functionality to add documentation to the macros created using `string_cache_codegen`.

It also copies the example from the README to the crate root docs.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/199)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: jdm
Pushing 4b80f2d to master...

@bors-servo bors-servo merged commit 8b33173 into servo:master Nov 22, 2017
bors-servo pushed a commit to servo/html5ever that referenced this pull request Jul 25, 2018
Add more documentation

I recently submitted a PR to add documentation. This PR adds some more.

Note it won't merge as-is because it relies on PR [#199 in servo/string-cache].

[#199 in servo/string-cache]: servo/string-cache#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants