Add criterion.rs to html5ever/xml5ever #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdm @SimonSapin Should I separate this PR into two PRs? Right now, inside this PR there is a pretty large, overhaul to x5e interface. Mainly to support speculative parsing, but I did it mostly, for interface parity. |
jdm
requested changes
Dec 13, 2018
Added additional dependcies, plus changed xml5ever interface in a major way.
Remove code reported as dead from benches.
1. Change String builder with `format!` macro 2. Replace parameter passing with just setting tokenization options to `Default`
|
@bors-servo r+ |
|
📌 Commit b8e9bed has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 14, 2018
Add criterion.rs to html5ever/xml5ever Fixes #45 and is a stepping stone for #286. Why is this important for #286? ----- It allows project to track it's performance, since [criterion.rs](https://github.com/bheisler/criterion.rs) generates benchmark data and tracks changes to performance. Possible enhancements ----- This is first pass at criterion. It's possible the performance could be better tracked, with more generic benchmarks. Possibly publishing this data, to see how it behaves overall. More tests for xml5ever, possibly tests that stress namespace rules and parts where xml is weak.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45 and is a stepping stone for #286.
Why is this important for #286?
It allows project to track it's performance, since criterion.rs generates benchmark data and tracks changes to performance.
Possible enhancements
This is first pass at criterion. It's possible the performance could be better tracked, with more generic benchmarks.
Possibly publishing this data, to see how it behaves overall.
More tests for xml5ever, possibly tests that stress namespace rules and parts where xml is weak.