feat: Update aws-node-http-api-typescript to v3 and Node 14
#679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielweinberger
changed the title
pgrzesik
suggested changes
Feb 8, 2022
Contributor
pgrzesik
left a comment
pgrzesik
left a comment
There was a problem hiding this comment.
Thank you @arielweinberger - let's keep the generation of README out of this PR for now, it seems like after recent changes we need to tweak it a bit. Otherwise it looks good 👍
This reverts commit 42a53f1.
Author
|
Done :) |
pgrzesik
approved these changes
Feb 11, 2022
Contributor
pgrzesik
left a comment
pgrzesik
left a comment
There was a problem hiding this comment.
Thank you @arielweinberger 🙇
pgrzesik
changed the title
aws-node-http-api-typescript to v3 and Node 14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted try out Serverless v3. When using the aws-node-http-api-typescript template (selected via the dashboard) and deploying right after creating the project, I faced an error:
This PR:
lambdaHashingVersionproperty from serverless.yml as it is deprecated.I tested this with a fresh deployment and it works fine!