-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Switch to HTTP APIs by default #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4e575e4
Switch to HTTP APIs by default for Node examples
mnapoli ac306a0
Switch to HTTP APIs by default for Java examples
mnapoli adabf04
Switch to HTTP APIs by default for other examples
mnapoli 34bbf42
Switch to HTTP APIs by default for Python examples
mnapoli 6580cdb
Switch to HTTP APIs by default for Node SQS example
mnapoli ce1d4cc
Switch to HTTP APIs by default for Ruby example
mnapoli feb66b1
Switch to HTTP APIs by default for Rust example
mnapoli 92a9925
Switch to HTTP APIs by default for Go example
mnapoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,17 @@ | ||
| service: aws-java-simple-http-endpoint | ||
|
|
||
| frameworkVersion: ">=1.2.0 <2.0.0" | ||
| frameworkVersion: '2' | ||
|
|
||
| provider: | ||
| name: aws | ||
| runtime: java8 | ||
|
|
||
| package: | ||
| artifact: build/distributions/aws-java-simple-http-endpoint.zip | ||
|
|
||
| functions: | ||
| currentTime: | ||
| handler: com.serverless.Handler | ||
| events: | ||
| - http: | ||
| path: ping | ||
| - httpApi: | ||
| path: /ping | ||
| method: get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| name: aws-node-express-api | ||
| org: serverlessinc | ||
| description: Deploys a Node Express API service with traditional Serverless Framework | ||
| description: Deploys a Node Express API service with Serverless Framework | ||
| keywords: aws, serverless, faas, lambda, node, express | ||
| repo: https://github.com/serverless/examples/aws-node-express-api | ||
| license: MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| name: aws-node-express-dynamodb-api | ||
| org: serverlessinc | ||
| description: Deploys a Node Express API service backed by DynamoDB with traditional Serverless Framework | ||
| description: Deploys a Node Express API service backed by DynamoDB with Serverless Framework | ||
| keywords: aws, serverless, faas, lambda, node, express, dynamodb | ||
| repo: https://github.com/serverless/examples/aws-node-express-dynamodb-api | ||
| license: MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,13 @@ | ||
| service: aws-node-express-dynamodb-api | ||
|
|
||
| frameworkVersion: '2' | ||
|
|
||
| custom: | ||
| tableName: 'users-table-${self:provider.stage}' | ||
| tableName: 'users-table-${sls:stage}' | ||
|
|
||
| provider: | ||
| name: aws | ||
| runtime: nodejs12.x | ||
| lambdaHashingVersion: '20201221' | ||
| stage: dev | ||
| iam: | ||
| role: | ||
| statements: | ||
|
|
@@ -30,12 +28,7 @@ functions: | |
| api: | ||
| handler: handler.handler | ||
| events: | ||
| - http: | ||
| path: / | ||
| method: ANY | ||
| - http: | ||
| path: /{proxy+} | ||
| method: ANY | ||
| - httpApi: '*' | ||
|
|
||
| resources: | ||
| Resources: | ||
|
|
@@ -48,7 +41,5 @@ resources: | |
| KeySchema: | ||
| - AttributeName: userId | ||
| KeyType: HASH | ||
| ProvisionedThroughput: | ||
| ReadCapacityUnits: 1 | ||
| WriteCapacityUnits: 1 | ||
| BillingMode: PAY_PER_REQUEST | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good call 👍
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 some templates had this, some others didn't. I figured we might as well make it consistent over this option, it's best to get started. |
||
| TableName: ${self:custom.tableName} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| .serverless | ||
| node_modules |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.