docs: Improve the docs of the aws-*-sqs-worker examples
#631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrzesik
reviewed
Jul 12, 2021
Contributor
pgrzesik
left a comment
pgrzesik
left a comment
There was a problem hiding this comment.
Well done @mnapoli and great call 👍 Would you be okay with adjusting the documentation for aws-python-sqs-worker in the same way? I believe it should be pretty much copy-and-paste as these parts of the doc are the same for both examples
Contributor
Author
|
Ah good point, thanks for that! I've pushed the same changes in the Python example too (mirrored the 2 READMEs). |
pgrzesik
changed the title
aws-*-sqs-worker examples
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went over the README to see if there was anything that could be improved.
This PR is very light, but I mostly tried to make documentation links more obvious (since this template includes Lift, which is pretty new to both new and experienced Framework users).
Slight changes also to remove a few words: for non-native English speakers, simpler sentences are always a bit easier to read.
That's a suggestion anyway, we can discuss this in the meeting later today!