Skip to content

Conversation

@pgrzesik
Copy link
Contributor

Use Lift plugin to simplify aws-node-sqs-worker and aws-python-sqs-worker examples

@pgrzesik pgrzesik self-assigned this Jun 24, 2021
@pgrzesik pgrzesik requested a review from medikoo June 24, 2021 14:42
@Pigius
Copy link
Contributor

Pigius commented Jun 24, 2021

Nice job @pgrzesik !

@pgrzesik
Copy link
Contributor Author

Thanks @Pigius 🙇

Copy link

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgrzesik looks great! I have just two comments

After running deploy, you should see output similar to:

```bash
``` bash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is not intended

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good catch 👍

# Serverless Framework Node SQS Producer-Consumer on AWS

This template demonstrates how to develop and deploy a simple SQS-based producer-consumer service running on AWS Lambda using the traditional Serverless Framework. It allows to accept messages, for which computation might be time or resource intensive, and offload their processing to an asynchronous background process for a faster and more resilient system.
This template demonstrates how to develop and deploy a simple SQS-based producer-consumer service running on AWS Lambda using the traditional Serverless Framework and Serverless Lift plugin. It allows to accept messages, for which computation might be time or resource intensive, and offload their processing to an asynchronous background process for a faster and more resilient system.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to link to Lift plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion - I've linked to queue docs but linking to Lift plugin at the beginning is a great call - changed

@pgrzesik pgrzesik force-pushed the use-lift-in-sqs-examples branch from 779d9ca to f817667 Compare June 25, 2021 10:47
@pgrzesik pgrzesik requested a review from medikoo June 25, 2021 10:48
Copy link

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pgrzesik pgrzesik merged commit 61a28e8 into master Jun 25, 2021
@pgrzesik pgrzesik deleted the use-lift-in-sqs-examples branch June 25, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants