Adding GET, LIST, PUT operations to rest-api-typescript-dynamodb #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eahefnawy
requested changes
Aug 28, 2020
|
|
||
| module.exports.list = (event, context, callback) => { | ||
| // fetch all todos from the database | ||
| dynamoDb.scan(params, (error, result) => { |
Contributor
There was a problem hiding this comment.
we really shouldn't be advocating using scan. I understand this is just an example though. Could you add a quick comment clarifying that in production query should be used instead?
Adding comment about pref. using query instead of scan to improve response time.
eahefnawy
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding code for GET, LIST and PUT operations as well as updating readme.md