Skip to content

Glue IAM role support #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Glue IAM role support #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/deploy/stepFunctions/compileIamRole.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,13 @@ function getBatchPermissions() {
}];
}

function getGluePermissions() {
return [{
action: 'glue:StartJobRun,glue:GetJobRun,glue:GetJobRuns,glue:BatchStopJobRun',
resource: '*',
}];
}

function getEcsPermissions() {
return [{
action: 'ecs:RunTask,ecs:StopTask,ecs:DescribeTasks',
Expand Down Expand Up @@ -181,6 +188,10 @@ function getIamPermissions(serverless, taskStates) {
case 'arn:aws:states:::batch:submitJob':
return getBatchPermissions();

case 'arn:aws:states:::glue:startJobRun.sync':
case 'arn:aws:states:::glue:startJobRun':
return getGluePermissions();

case 'arn:aws:states:::ecs:runTask.sync':
case 'arn:aws:states:::ecs:runTask':
return getEcsPermissions();
Expand Down
40 changes: 40 additions & 0 deletions lib/deploy/stepFunctions/compileIamRole.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,46 @@ describe('#compileIamRole', () => {
}]);
});

it('should give glue permissions (too permissive, but mirrors console behaviour)', () => {
const genStateMachine = (name) => ({
name,
definition: {
StartAt: 'A',
States: {
A: {
Type: 'Task',
Resource: 'arn:aws:states:::glue:startJobRun',
Next: 'B',
},
B: {
Type: 'Task',
Resource: 'arn:aws:states:::glue:startJobRun.sync',
End: true,
},
},
},
});

serverless.service.stepFunctions = {
stateMachines: {
myStateMachine1: genStateMachine('stateMachineBeta1'),
myStateMachine2: genStateMachine('stateMachineBeta2'),
},
};

serverlessStepFunctions.compileIamRole();
const statements = serverlessStepFunctions.serverless.service
.provider.compiledCloudFormationTemplate.Resources.IamRoleStateMachineExecution
.Properties.Policies[0].PolicyDocument.Statement;

const gluePermissions = statements.filter(s =>
_.isEqual(s.Action,
['glue:StartJobRun', 'glue:GetJobRun', 'glue:GetJobRuns', 'glue:BatchStopJobRun'])
);
expect(gluePermissions).to.have.lengthOf(1);
expect(gluePermissions[0].Resource).to.equal('*');
});

it('should give ECS permissions (too permissive, but mirrors console behaviour)', () => {
const genStateMachine = (name) => ({
name,
Expand Down