Avoid alarms logs when no alarms are defined #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way `validateConfig` works will generate some error logs when no alamrs are defined at all. After upgrading to the latest serverless-step-functions we got some logs about alarms but we don't have alarms defined. I think we should not have log about "alarms config is malformed" when no alarms are defined.
|
This has been deployed as part of |
ss-betseqnzr
pushed a commit
to BetSEQNZR/serverless-step-functions
that referenced
this pull request
Sep 8, 2023
…-no-alarms Avoid alarms logs when no alarms are defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
validateConfigworks will generate some error logs when no alarms are defined at all.After upgrading to the latest serverless-step-functions we got some logs about alarms but we don't have alarms defined. I think we should not have log about "alarms config is malformed" when no alarms are defined.
Following #167
Sidenote: I've enable
sinon.spy()instead ofconsole.logincompileIamRole.test.jsto avoid noisy log during tests. I can remove that if you don't agree.