Service endpoint fix

[dannyshisler]

The ServiceEndpoint output value for endpoints urls generated by the Serverless framework is being overwritten incorrectly by the serverless-step-functions plugin.

I've described the issue in detail here: #149

This PR changes the ServiceEndpoint generation for API gateway deployments to match the output generated by Serverless framework.

[horike37]

@dannyshisler
Thank you for take care of that 👍
LGTM 💯

[brian-fivetalent]

With serverless-step-functions version 1.24.0 I am still seeing my cloudformation output as follows
https://{XXXX}.execute-api.us-west-2.amazonaws.com/devamazonaws.com/dev

I found this in the output cloudformation

  ServiceEndpoint:
    Description: URL of the service endpoint
    Value: !Join 
      - ''
      - - 'https://'
        - !Ref ApiGatewayRestApi
        - .execute-api.us-west-2.
        - !Ref 'AWS::URLSuffix'
        - /dev
        - !Ref 'AWS::URLSuffix'
        - /dev

EDIT for anyone still finding this I had to run

serverless plugin uninstall --name serverless-step-functions

serverless plugin install --name serverless-step-functions and

sls deploy --force

EDIT EDIT I am still running into the issue when AWS code-build runs all three of the above functions. Using a Linux Container with Node 8

[theburningmonk]

@brian-fivetalent verified the issue and got a fix coming up

[theburningmonk]

@brian-fivetalent try again on 1.24.1

[brian-fivetalent]

@theburningmonk thank you! With 1.24.1 it is working as expected.