Add support for CloudFormation intrinsic function for role #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horike37
requested changes
Mar 15, 2018
There was a problem hiding this comment.
Thank you for the PR @alex-berger 👍
Unfortunately, some linting error occurs. Could you fix those?
|
Linting issues fixed. |
horike37
reviewed
Apr 24, 2018
| const _ = require('lodash'); | ||
| const BbPromise = require('bluebird'); | ||
|
|
||
| function isIntrinsic(obj) { |
There was a problem hiding this comment.
Why is this function outside module.exports? Would be good to be inside that.
horike37
requested changes
Apr 24, 2018
There was a problem hiding this comment.
@alex-berger
Sorry for the delay response. Thank you for fixing the linting errors.
I have reviewed the code and left one comment for improvements.
And, cloud you add an explanation of this functionality within README so that let users know it
bweigel
pushed a commit
to bweigel/serverless-step-functions
that referenced
this pull request
Dec 6, 2018
- based on PR serverless-operations#111 - thanks @alex-berger - see serverless-operations#111
bweigel
pushed a commit
to bweigel/serverless-step-functions
that referenced
this pull request
Dec 6, 2018
bweigel
pushed a commit
to bweigel/serverless-step-functions
that referenced
this pull request
Dec 6, 2018
|
Just a quick note that this feature is mentioned in the docs, but the syntax in the docs does not match the syntax shown by @alex-berger and therefore led me astray until I found this. |
ss-betseqnzr
pushed a commit
to BetSEQNZR/serverless-step-functions
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for CloudFormation intrinsic functions to the
roleproperty, such for example the following sytanx is supported:Having this feature in place, it is now possible to use (refer to) IAM roles which are defined in the
Resourcessection of theserverless.ymlfile.