Skip to content

Do not display endpoints if there are none #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Do not display endpoints if there are none #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28cc1b0
Do not display endpoints if there are none
j0k3r Mar 7, 2018
038ebac
use lodash for if-check
horike37 Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,12 @@ class ServerlessStepFunctions {

display() {
let message = '';
let stateMachineMessages = '';

const endpointInfo = this.endpointInfo;
message += `${chalk.yellow.underline('Serverless StepFunctions OutPuts')}\n`;
message += `${chalk.yellow('endpoints:')}`;

if (this.isStateMachines()) {
_.forEach(this.getAllStateMachines(), (stateMachineName) => {
const stateMachineObj = this.getStateMachine(stateMachineName);
Expand All @@ -159,14 +161,22 @@ class ServerlessStepFunctions {
path = event.http.split(' ')[1];
}
path = path !== '/' ? `/${path.split('/').filter(p => p !== '').join('/')}` : '';
message += `\n ${method} - ${endpointInfo}${path}`;
stateMachineMessages += `\n ${method} - ${endpointInfo}${path}`;
}
});
}
});
}

if (_.isEmpty(stateMachineMessages)) {
return '';
}

message += stateMachineMessages;
message += '\n';

this.serverless.cli.consoleLog(message);

return message;
}
}
Expand Down
21 changes: 6 additions & 15 deletions lib/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,9 @@ describe('#index', () => {

it('should not display endpoints if http event not given', () => {
serverlessStepFunctions.serverless.service.stepFunctions = {};
let expectedMessage = '';
expectedMessage += `${chalk.yellow.underline('Serverless StepFunctions OutPuts')}\n`;
expectedMessage += `${chalk.yellow('endpoints:')}`;
expectedMessage += '\n';
const expectedMessage = '';
const message = serverlessStepFunctions.display();
expect(consoleLogStub.calledOnce).to.equal(true);
expect(consoleLogStub.calledOnce).to.equal(false);
expect(message).to.equal(expectedMessage);
});

Expand Down Expand Up @@ -337,12 +334,9 @@ describe('#index', () => {
},
},
};
let expectedMessage = '';
expectedMessage += `${chalk.yellow.underline('Serverless StepFunctions OutPuts')}\n`;
expectedMessage += `${chalk.yellow('endpoints:')}`;
expectedMessage += '\n';
const expectedMessage = '';
const message = serverlessStepFunctions.display();
expect(consoleLogStub.calledOnce).to.equal(true);
expect(consoleLogStub.calledOnce).to.equal(false);
expect(message).to.equal(expectedMessage);
});

Expand All @@ -359,12 +353,9 @@ describe('#index', () => {
},
},
};
let expectedMessage = '';
expectedMessage += `${chalk.yellow.underline('Serverless StepFunctions OutPuts')}\n`;
expectedMessage += `${chalk.yellow('endpoints:')}`;
expectedMessage += '\n';
const expectedMessage = '';
const message = serverlessStepFunctions.display();
expect(consoleLogStub.calledOnce).to.equal(true);
expect(consoleLogStub.calledOnce).to.equal(false);
expect(message).to.equal(expectedMessage);
});
});
Expand Down