Skip to content

Conversation

vonpoland
Copy link
Contributor

Description

Adding private:true to state machine events

"events": [
      {
        "http": {
          "path": "delijn/bookings/callback",
          "method": "post",
          "private": true
        }
      }
    ]

Should set ApiKeyRequired: true in AWS::ApiGateway::Method template.
https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-setup-api-key-with-restapi.html

Without this parameter x-api-keys are ignored.

Fix description

private:true is now handled and used in AWS::ApiGateway::Method.

Copy link
Collaborator

@horike37 horike37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @vonpoland 👍
Thanks 😄

@horike37 horike37 merged commit f8105e1 into serverless-operations:master Mar 16, 2018
@horike37 horike37 added this to the 1.4 milestone Apr 10, 2018
ss-betseqnzr pushed a commit to BetSEQNZR/serverless-step-functions that referenced this pull request Sep 8, 2023
…dd-private-mode-to-http-events

Added handling of 'private' param to http events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants