Skip to content

feat(simulator): Add support for multiple AppSync APIs #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2021
Merged

feat(simulator): Add support for multiple AppSync APIs #92

merged 2 commits into from
Apr 25, 2021

Conversation

louislatreille
Copy link
Contributor

@louislatreille louislatreille commented Apr 21, 2021 •
edited by bboure
Loading

This adds support for simulating multiple AppSync APIs.

The new code has been tested with a serverless config containing 1 API, and another one containing many APIs. The simulator and hot-reloading still work as expected.

Closes #90

@louislatreille louislatreille force-pushed the supportMultipleAppSyncApis branch from 2485f39 to 40f3372 Compare April 21, 2021 16:07
@louislatreille louislatreille mentioned this pull request Apr 21, 2021
Closed
bboure
bboure requested changes Apr 21, 2021
View reviewed changes
Copy link
Member

@bboure bboure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you! 🚀

LGTM. I only have one comment:

We have a pretty wide port range available here (at least in the default), I would increment the port number by 10. It would be easier for humans to calculate mentally.

It also leaves some room for possible future usage.

20002
20003
20012
20013 
20022
20023

@louislatreille louislatreille force-pushed the supportMultipleAppSyncApis branch from 40f3372 to 6cc7275 Compare April 21, 2021 17:06
@louislatreille
Copy link
Contributor Author

Great suggestion! I've made the change.

@louislatreille louislatreille requested a review from bboure April 22, 2021 19:47
@bboure
Copy link
Member

bboure commented Apr 23, 2021

Great, thank you! I'll try to review this and merge over the weekend 🙏

bboure
bboure approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@bboure bboure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @louislatreille
Looks awesome! Great work! 🎉

I just pushed a fix for the linter and ran prettier on the code.

@bboure bboure changed the title Add support for multiple AppSync APIs feat(simulator): Add support for multiple AppSync APIs Apr 25, 2021
@bboure bboure merged commit 0b0daa2 into serverless-appsync:master Apr 25, 2021
@bboure
Copy link
Member

bboure commented Apr 25, 2021

@all-contributors please add @louislatreille for code

@allcontributors allcontributors bot mentioned this pull request Apr 25, 2021
Merged
@allcontributors
Copy link
Contributor

@bboure

I've put up a pull request to add @louislatreille! 🎉

bboure pushed a commit that referenced this pull request Apr 25, 2021
@semantic-release-bot
chore(release): 0.16.0 [skip ci]
2c16754 
# [0.16.0](v0.15.0...v0.16.0) (2021-04-25)

### Features

* **simulator:** Add support for multiple AppSync APIs ([#92](#92)) ([0b0daa2](0b0daa2))
@bboure
Copy link
Member

bboure commented Apr 25, 2021

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hiramatsutaku hiramatsutaku mentioned this pull request Apr 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboure bboure bboure approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use the plugin with multiple AppSync APIs
2 participants
@louislatreille @bboure