Networking #17
Open
Networking #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add pre_stop function to actors, that is executed before mailbox is closed to enable a clean shutdown for network connections (i.e. drop new connections but finish open communication with existing connections for http requests) - add optional signal handling to start a clean shutdown for SIGINT
…erent network handler implementations
…make ActorAddress public; add ActorBuilder.get_existing(); improve serialize example
…op(), network management and signal handling; also allow endless waiting through 0
|
there's definitely some performance regression in comparison to the current release. Nonetheless we should ensure that these regressions are not related to dependency upgrades and that they are indeed necessary. Furthermore the implemented bincode library changed heavily in the latest release compared to the used release. I'm kind of unhappy that there's a new trait required in the latest release and that the Serialize trait is no longer sufficient. We should check if we really want to stick with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this merge request lays the initial ground work for networking support in tyra and is a pre-requisite to any kind of clustering