Skip to content

I have changed the registration of the LoggerProvider with using a factory for creating an instance. #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2018
Merged

I have changed the registration of the LoggerProvider with using a factory for creating an instance. #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Serilog.Extensions.Logging/SerilogLoggingBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#if LOGGING_BUILDER

using System;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using Serilog.Extensions.Logging;

Expand All @@ -38,7 +39,15 @@ public static ILoggingBuilder AddSerilog(this ILoggingBuilder builder, ILogger l
{
if (builder == null) throw new ArgumentNullException(nameof(builder));

builder.AddProvider(new SerilogLoggerProvider(logger, dispose));
if (dispose)
{
builder.Services.AddSingleton<ILoggerProvider, SerilogLoggerProvider>(services => new SerilogLoggerProvider(logger, true));
}
else
{
builder.AddProvider(new SerilogLoggerProvider(logger));
}

builder.AddFilter<SerilogLoggerProvider>(null, LogLevel.Trace);

return builder;
Expand Down