Add support for ICustomFormatter through the user-supplied format provider
#133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132
In
CompiledMessageToken.cs, beyond the special cases ofnullandstring, for which the library does rendering that's different to that of Serilog's built-inScalarValue.Rendermethod (e.g. unquoted strings), we're delegating to the aforementioned method; which internally supportsICustomFormatters — see this. I don't suspect a breaking change; the new behavior with regards to theformatProviderargument is a strict subset of the new behavior. Meaning existing users' suppliedformatProviders will continue to work as they were before.I'm just not sure if the implementation is complete. Let me know if I've missed something.
Let me know if you approve of the approach, and if so, I could also add some tests for the feature.