Skip to content

Conversation

gumbarros
Copy link
Contributor

This closes #636

@ckadluba
Copy link
Member

ckadluba commented Sep 29, 2025

Thank you for the PR @gumbarros! After a first glance at the code, it looks quite good. A few tings are still to be done.

  1. There is one or more failing tests.
  2. The new config parameter also has to be read from config files (check out the code in src/Serilog.Sinks.MSSqlServer/Configuration)
  3. Add tests for the new functionality (especially in SqlTableWriter)

@gumbarros
Copy link
Contributor Author

Yw @ckadluba, sorry for the late response.

I have added support for reading the new config parameter from the config files. However, I'm not very familiar with the test setup and I'm feeling a bit overwhelmed by the complexity of fixing and writing the tests. I'd really appreciate some help from someone with that part.

@ckadluba
Copy link
Member

Thank you for the updates on the PR. I'll try to take a look at it tomorrow and I will also try to help with the tests.

* Added unit tests for MicrosoftExtensionsColumnOptionsProvider, MicrosoftExtensionsColumnOptionsProviderTests and SqlCreateTableWriter
* Added SetProperty.IfEnumNotNull<T>() and SetProperty.IfEnumProvided<T>() to handle enum column option reading from configuration
* Use NonClusteredIndexDirection in WorkerServiceDemo

Related issue: serilog-mssql#636
@ckadluba
Copy link
Member

ckadluba commented Oct 16, 2025

Hi @gumbarros!

I reviewed your PR. It looks quite good basically but it had to make made some fixes and add some tests (nothing big). My changes are pushed here: https://github.com/ckadluba/serilog-sinks-mssqlserver/tree/issue-636-timestamp-indexdirection. Please pull them into your branch and update the PR, then we should be ready to merge.

Cheers,
Christian

@gumbarros
Copy link
Contributor Author

Hi @gumbarros!

I reviewed your PR. It looks quite good basically but it had to make made some fixes and add some tests (nothing big). My changes are pushed here: https://github.com/ckadluba/serilog-sinks-mssqlserver/tree/issue-636-timestamp-indexdirection. Please pull them into your branch and update the PR, then we should be ready to merge.

Cheers, Christian

image

Thank you, I made the pull and it said everything is fine, can you run CI again?

Cheers,

Gustavo

@ckadluba ckadluba added this pull request to the merge queue Oct 17, 2025
Merged via the queue into serilog-mssql:dev with commit 71e291e Oct 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configuring index direction for TimeStamp.NonClusteredIndex

2 participants