Skip to content

Conversation

@eriktks
Copy link
Member

@eriktks eriktks commented Mar 25, 2021

Ref: #6

  • Refactored notebook test_mvp.ipynb: split main code block in smaller parts and added more comments
  • Additionally added environment include line for Jupyter Lab to README

To test: install notebook according to installation instructions in README.md and verify that the notebook works

Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@eriktks eriktks merged commit 01cf740 into main Mar 30, 2021
@eriktks eriktks deleted the 6-refactor-test_mvp.ipynb branch March 30, 2021 12:33
@eriktks
Copy link
Member Author

eriktks commented Mar 30, 2021

Thanks!

@eriktks eriktks mentioned this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants