-
Notifications
You must be signed in to change notification settings - Fork 66
Create Pull Request Template #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
<!-- | ||
Please explain WHAT you changed and WHY. | ||
|
||
The title should be descriptive, for example: | ||
|
||
* *Fixed a typo in the apikeypermissions.md page* | ||
* *Added the maximum number of domain whitelabels you can create to domains.md* | ||
* *Fixing the number of days a batch id is valid in scheduling_parameters.md* | ||
|
||
If this PR fixes an issue, please reference the issue number as well. | ||
|
||
Fill out this form in the body: | ||
--> | ||
|
||
**Description of the change**: | ||
|
||
**Reason for the change**: | ||
|
||
**Link to original source**: | ||
|
||
### Checklist | ||
|
||
Make sure all of these items are complete, or else the PR will be ineligible for a code review. | ||
|
||
- [ ] Code passes all existing [tests](https://github.com/sendgrid/php-http-client/tree/master/test) | ||
- [ ] Any new functionality added includes new unit tests in [`tests/unit`](https://github.com/sendgrid/php-http-client/tree/master/test/unit) | ||
- [ ] Create or update example code to show the new functionality in action. | ||
- [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/php-http-client/blob/master/CONTRIBUTING.md#style-guidelines-and-naming-conventions)) | ||
- [ ] Feature branch has been rebased off of the latest `master` branch. (see [`CONTRIBUTING.md`](https://github.com/sendgrid/php-http-client/blob/master/CONTRIBUTING.md#creating-a-pull-request)). | ||
|
||
If you have questions, please send an email [Sendgrid](mailto:[email protected]), or file a Github Issue in this repository. | ||
|
||
<!-- | ||
Template based off of @ksigler7's Sendgrid docs PR template. | ||
https://raw.githubusercontent.com/sendgrid/docs/develop/.github/PULL_REQUEST_TEMPLATE | ||
@hydrosquall | ||
--> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove this? I should have added that to the issue. Sorry!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks for pointing that out.