Skip to content

Pass the curlOptions to the client in buildClient #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Pass the curlOptions to the client in buildClient #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ private function buildClient($name = null)
if (isset($name)) {
$this->path[] = $name;
}
$client = new Client($this->host, $this->headers, $this->version, $this->path);
$client = new Client($this->host, $this->headers, $this->version, $this->path, $this->curlOptions);
$this->path = [];
return $client;
}
Expand Down
7 changes: 5 additions & 2 deletions test/unit/ClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,11 @@ public function testConstructor()

public function test_()
{
$client = $this->client->_('test');
$client = new MockClient($this->host, $this->headers, '/v3', null, ['foo' => 'bar']);
$client = $client->_('test');

$this->assertAttributeEquals(['test'], 'path', $client);
$this->assertAttributeEquals(['foo' => 'bar'], 'curlOptions', $client);
}

public function test__call()
Expand Down Expand Up @@ -106,4 +109,4 @@ public function testGetCurlOptions()
$client = new Client('https://localhost:4010', null, null, null, null);
$this->assertSame([], $client->getCurlOptions());
}
}
}