Skip to content
This repository was archived by the owner on Aug 20, 2020. It is now read-only.

Conversation

@maxtotterman
Copy link
Contributor

@maxtotterman maxtotterman commented Oct 27, 2017

Added esdoc as proposed in #42 issue.

  • Saved the libraries in dev dependencies instead.
  • Added both documentations to CONTRIBUTING.md file since USAGE.md didn't exist.

Let me know if there should be any corrections.

Closes: #42

@SendGridDX
Copy link

SendGridDX commented Oct 27, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The USAGE file might have been merged while you were making this PR - can you please update the file here: https://github.com/sendgrid/nodejs-http-client/blob/master/USAGE.md

@maxtotterman
Copy link
Contributor Author

Should be ok now.

@mbernier
Copy link
Contributor

W00t!

@mbernier mbernier merged commit ce24cec into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

Hello @maxtotterman,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier mbernier mentioned this pull request Oct 28, 2017
@thinkingserious thinkingserious changed the title Added esdoc chore: Added esdoc Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add esdoc support

4 participants