Skip to content

Update README.md #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 25, 2020
Merged

Update README.md #3

merged 9 commits into from
Nov 25, 2020

Conversation

sf-jeff-lim
Copy link
Contributor

No description provided.


<br />

## Implementation guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between Implementation guide and Making your first call? Much of these two sections seem duplicated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We know about this, but we think it's okay to keep the duplicated content in the Implementation guide section because a visitor can directly move to the section according to their own needs without seeing Making your first call section.

When we all can start a total renewal of this README.md, let's discuss this.

@jungdj
Copy link
Contributor

jungdj commented Nov 20, 2020

Is this a total renewal or just a structural re-organization? If it's the second case, LGTM

@sf-jeff-lim
Copy link
Contributor Author

It's just a structural re-organization and minor updates on the sentences.

@famous90 famous90 merged commit e22564a into sendbird:master Nov 25, 2020
@sf-jeff-lim sf-jeff-lim deleted the patch-1 branch November 25, 2020 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants