Skip to content

Avoid notifications on Edge when possible #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Avoid notifications on Edge when possible #1898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cdb1d9
Avoid notifications on Edge when possible
mdmintz Jun 6, 2023
0935b11
Update an example test
mdmintz Jun 6, 2023
b449fe5
Version 4.14.13
mdmintz Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions examples/presenter/edge_presentation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def test_presentation(self):
self.play_tour()
self.highlight('img[src*="microsoft-edge-version"]')

self.get_new_driver(browser="edge", disable_csp=True)
self.get_new_driver(browser="edge")
self.maximize_window()
self.open("edge://settings/help")
zoom_in = (
Expand Down Expand Up @@ -144,19 +144,24 @@ def test_presentation(self):
self.play_tour()
self.highlight('[href*="microsoft-edge/tools/webdriver"]')

self.get_new_driver(browser="edge", disable_csp=True)
self.get_new_driver(browser="edge")
self.maximize_window()
self.open(
"https://developer.microsoft.com/en-us/"
"microsoft-edge/tools/webdriver/"
)
self.wait_for_element("#page-heading")
self.create_tour(theme="introjs")
self.add_tour_step("You need this", "#page-heading", alignment="right")
self.add_tour_step("If you can", "#downloads-channel", alignment="top")
self.add_tour_step("Available files", "#downloads", alignment="bottom")
self.add_tour_step("More info", "#installation", alignment="top")
self.play_tour()
self.scroll_to("#page-heading")
zoom_in = '#page-heading{zoom: 1.2;-moz-transform: scale(1.2);}'
self.add_css_style(zoom_in)
self.highlight("#page-heading", loops=8)
self.sleep(1.2)
self.highlight("#downloads-channel", loops=8)
self.sleep(1.2)
self.highlight("#downloads", loops=12)
self.sleep(1.8)
self.highlight("#installation", loops=12)
self.sleep(1.8)
self.quit_extra_driver()

self.switch_to_default_driver()
Expand Down
2 changes: 1 addition & 1 deletion seleniumbase/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# seleniumbase package
__version__ = "4.14.12"
__version__ = "4.14.13"
5 changes: 4 additions & 1 deletion seleniumbase/core/browser_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2253,7 +2253,10 @@ def get_local_driver(
)
if not enable_sync:
edge_options.add_argument("--disable-sync")
if guest_mode or IS_WINDOWS:
if (
(guest_mode or IS_WINDOWS or selenium4_or_newer)
and not recorder_ext and not disable_csp
):
edge_options.add_argument("--guest")
if headless2:
try:
Expand Down