Skip to content

Fix be rpc leaks in rpc factory #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix be rpc leaks in rpc factory #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/rpc/rpc_factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ type RpcFactory struct {
feRpcs map[*base.Spec]IFeRpc
feRpcsLock sync.Mutex

beRpcs map[*base.Backend]IBeRpc
beRpcs map[base.Backend]IBeRpc
beRpcsLock sync.Mutex
}

func NewRpcFactory() IRpcFactory {
return &RpcFactory{
feRpcs: make(map[*base.Spec]IFeRpc),
beRpcs: make(map[*base.Backend]IBeRpc),
beRpcs: make(map[base.Backend]IBeRpc),
}
}

Expand Down Expand Up @@ -57,7 +57,7 @@ func (rf *RpcFactory) NewFeRpc(spec *base.Spec) (IFeRpc, error) {

func (rf *RpcFactory) NewBeRpc(be *base.Backend) (IBeRpc, error) {
rf.beRpcsLock.Lock()
if beRpc, ok := rf.beRpcs[be]; ok {
if beRpc, ok := rf.beRpcs[*be]; ok {
rf.beRpcsLock.Unlock()
return beRpc, nil
}
Expand All @@ -77,6 +77,6 @@ func (rf *RpcFactory) NewBeRpc(be *base.Backend) (IBeRpc, error) {

rf.beRpcsLock.Lock()
defer rf.beRpcsLock.Unlock()
rf.beRpcs[be] = beRpc
rf.beRpcs[*be] = beRpc
return beRpc, nil
}
Loading