Skip to content

Conversation

@huszkacs
Copy link

GroupInstanceID can be configured by setting ReaderConfig.GroupInstanceID which will be passed to the joinGroup and heartbeat requests. If the GroupInstanceID has a value the kafka server will set it as a static member.

@rhansen2
Copy link
Collaborator

rhansen2 commented Oct 5, 2022

Hi @huszkacs,

Thanks for submitting this PR!. Just wanted to clarify if this PR is meant to fully support the behavior described in https://cwiki.apache.org/confluence/display/KAFKA/KIP-345:+Introduce+static+membership+protocol+to+reduce+consumer+rebalances#KIP345:Introducestaticmembershipprotocoltoreduceconsumerrebalances-ClientSideChanges or if you're just looking to support passing the GroupInstanceID?

@huszkacs
Copy link
Author

@rhansen2 it is meant to fully support the behaviour. Thanks to the new structure, there is no need for any other change. Previously I had more complicated PR.

(sorry for the late answer)

@rhansen2
Copy link
Collaborator

It looks like https://cwiki.apache.org/confluence/display/KAFKA/KIP-345:+Introduce+static+membership+protocol+to+reduce+consumer+rebalances describes some changes to the client behavior, specifically For the effectiveness of the KIP, consumer with group.instance.id set will not send leave group request when they go offline and some changes to the range balancer. Are we already compliant with those behaviors?

@huszkacs
Copy link
Author

that is a good question, I take a look

@rhansen2 rhansen2 closed this Feb 11, 2023
@rhansen2
Copy link
Collaborator

Closed due to inactivity as well as some of the changes this depended on being reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants