Skip to content

Update WriteErrors error message #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 2, 2022
Merged

Update WriteErrors error message #964

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29ac76c
Update WriteErrors error message
mhmtszr Aug 3, 2022
0fcb094
Update error.go
Aug 5, 2022
719991c
Handle error nil case
mhmtszr Aug 28, 2022
c5a8f4d
Update error message for write errors
mhmtszr Sep 2, 2022
b866e78
preallocate the errors slice
mhmtszr Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,6 @@ func makeError(code int16, message string) error {
// // handle other errors
// ...
// }
//
type WriteErrors []error

// Count counts the number of non-nil errors in err.
Expand All @@ -701,5 +700,13 @@ func (err WriteErrors) Count() int {
}

func (err WriteErrors) Error() string {
return fmt.Sprintf("kafka write errors (%d/%d)", err.Count(), len(err))
errCount := err.Count()
errors := make([]string, 0, errCount)
for _, writeError := range err {
if writeError == nil {
continue
}
errors = append(errors, writeError.Error())
}
return fmt.Sprintf("Kafka write errors (%d/%d), errors: %v", errCount, len(err), errors)
}