[AJS 2.0] Resolve domify 1.4.1 for every integration #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a potential XSS vulnerability present in every single destination library for AJS 2.0 only.
We do this by telling webpack to always resolve
domifyon version1.4.1when building the destination libraries.Testing
Any background context you want to provide?
Domify is used by
analytics.js-integration, the base code for every destination library we have.Ideally, we should have
analytics.js-integrationupdated for every destination, but that would require updating 180+ libraries and running a release train for all of them. In addition, not all libraries use the latest version ofanalytics.js-integration, increasing the amount of changes deployed.sindresorhus/domify#48