Skip to content

Don't swallow integration errors #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Don't swallow integration errors #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions lib/protos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,16 +174,9 @@ exports.invoke = function(method) {
if (!this[method]) return;
var args = Array.prototype.slice.call(arguments, 1);
if (!this._ready) return this.queue(method, args);
var ret;

try {
this.debug('%s with %o', method, args);
ret = this[method].apply(this, args);
} catch (e) {
this.debug('error %o calling %s with %o', e, method, args);
}

return ret;
this.debug('%s with %o', method, args);
return this[method].apply(this, args);
};

/**
Expand Down
6 changes: 4 additions & 2 deletions test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,10 +292,12 @@ describe('integration', function() {
assert(integration.track.calledWith('event'));
});

it('should catch errors when it calls', function() {
it('should throw errors if the integration errors', function() {
integration.emit('ready');
integration.initialize();
integration.invoke('page', 'name');
assert['throws'](function() {
integration.invoke('page', 'name');
}, Error, 'Should not swallow exceptions');
});

it('should return the returned value', function(done) {
Expand Down