This repository was archived by the owner on Jun 27, 2019. It is now read-only.
Support "Completed Order" #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support the legacy "Completed Order" event name. Some customers still use that, and this change will allow them to use Optimizely as intended without changing their code base.
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=========================================
- Coverage 98.11% 98.1% -0.02%
=========================================
Files 1 1
Lines 159 158 -1
=========================================
- Hits 156 155 -1
Misses 3 3
Continue to review full report at Codecov.
|
Peripheral1994
approved these changes
Sep 7, 2017
|
Whoever deploys this, remember to bump package.json and the HISTORY.md accordingly. :) |
|
@Peripheral1994 what happened to this? also might be better to just have |
|
Hi @srthurman, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you! For more information, see README.md. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the legacy "Completed Order" event name. Some customers still use that, and this change will allow them to use Optimizely as intended without changing their code base.